Message-Id: <200007070837.LAA00403@mailgw1.netvision.net.il>
Date: Fri, 07 Jul 2000 11:37:31 +0200
To: "Juan Manuel Guerrero" <ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De>
X-Mailer: Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
CC: djgpp AT delorie DOT com
In-reply-to: <8C684AC7AE1@HRZ1.hrz.tu-darmstadt.de>
	(ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De)
Subject: Re: A remark about unzip32
References:  <8C684AC7AE1 AT HRZ1 DOT hrz DOT tu-darmstadt DOT de>
Reply-To: djgpp AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: "Juan Manuel Guerrero" <ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De>
> Date: Fri, 7 Jul 2000 08:34:02 +0200
> 
> Unzip32 has an, in my opinion, somewhat "peculiar" algorithm
> for truncating long file names into short file names on plain DOS.

Thanks for reporting this.

I know about this problem with InfoZip's programs for quite some time
(discovered it with Textutils, as you did).  My version of UnZip is
very old, and since no one until now complained about the Textutils
test suite, I was hoping that this is fixed in later versions.
Evidently, it isn't.

> I had the sources of unzip532 available so I can
> send a patch that shows were the difficulty is located.
> The "bug" is in function map2fat in file unz532/msdos/msdos.c.
> 1) I know that this is not the appropiate place to send this
> patch but the intention is to call your attention to this difficulty.
> 2) This patch shall only show where the bug is and not
> fix it. The patch simply defines out the faulty part of the
> function. This is probably a too crude approach.

I think unzip in its DJGPP version should simply reuse the code from
DJTAR.  (With minor changes, the same code is in the DJGPP ports of
GNU Tar and cpio.)  Or just truncate the name to 8+3 and forget all
the other trickery.  In any case, I suggest to send diffs to the UnZip
maintainers.