X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f From: Andris Pavenis To: Ian Lance Taylor Subject: Re: [libiberty] [PATCH] Fix breakage of pex-djgpp.c in HEAD branch Date: Tue, 19 Apr 2005 09:06:33 +0300 User-Agent: KMail/1.8 Cc: gcc-patches AT gcc DOT gnu DOT org, djgpp-workers AT delorie DOT com References: <200504181901 DOT 29986 DOT pavenis AT latnet DOT lv> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200504190906.33234.pavenis@latnet.lv> X-Virus-Scanned: amavisd-new at fgi.fi Reply-To: djgpp-workers AT delorie DOT com On Monday 18 April 2005 20:22, Ian Lance Taylor wrote: > Andris Pavenis writes: > > 2004-04-18 Andris Pavenis > > > > * pex-djgpp.c: Add missing includes > > (pex_init) Add missing ; for last parameter in call to pex_init_common > > (pex_djgpp_exec_child) Use dup(), dup2(), close() instead of _dup(), > > _dup2(), _close(). > > Thanks for fixing these issues. There is now a simple test of the > pexecute functions, which may or may not work on DJGPP. Can you > please try running "make check-libiberty" in your object directory, to > see what happens? Thanks. Tried ('make all-libiberty check-libiberty') make.exe[1]: Entering directory `g:/build/gcc41/gnu/build.gcc/libiberty' make.exe[2]: Entering directory `g:/build/gcc41/gnu/build.gcc/libiberty/testsuite' ./test-demangle < /build/gcc41/gnu/gcc-4.10-20050414-experimental/libiberty/testsuite/demangle-expected ./test-demangle.exe: 746 tests, 0 failures ./test-pexecute test-pexecute:273: abort failed test-pexecute:365: echoerr exit status failed test-pexecute:422: write exit status 2 failed make.exe[2]: *** [check-pexecute] Error 3 make.exe[2]: Leaving directory `g:/build/gcc41/gnu/build.gcc/libiberty/testsuite' make.exe[1]: *** [check-subdir] Error 2 make.exe[1]: Leaving directory `g:/build/gcc41/gnu/build.gcc/libiberty' make.exe: *** [check-libiberty] Error 2 First failure seems to be of class XFAIL as far as I looked. I didn't have time still to study other ones in details. Andris