X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
Date: Tue, 11 Nov 2003 10:59:39 +0200 (EET)
From: Esa A E Peuha <peuha AT cc DOT helsinki DOT fi>
Sender: peuha AT sirppi DOT helsinki DOT fi
To: djgpp-workers AT delorie DOT com
Subject: Re: djgpp: djgpp/src/libc/go32/makefile,overflow.S
In-Reply-To: <3FAFEC80.E3DF81F8@phekda.freeserve.co.uk>
Message-ID: <Pine.OSF.4.58.0311111046350.6448@sirppi.helsinki.fi>
References: <200311070952 DOT hA79qp0D028636 AT delorie DOT com> <3FACDD1E DOT 4950D38B AT phekda DOT freeserve DOT co DOT uk>
 <Pine DOT OSF DOT 4 DOT 58 DOT 0311101328470 DOT 17387 AT sirppi DOT helsinki DOT fi>
 <3FAFEC80 DOT E3DF81F8 AT phekda DOT freeserve DOT co DOT uk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Mon, 10 Nov 2003, Richard Dawe wrote:

> > @c ----------------------------------------------------------------------
> > @node Stack overflow handler, signal

Would it be better to change "signal" to "internal", since this is not
meant to be used directly by applications.  There's no "internal"
category yet, but I think there should be (with more entries than just
this one).

> > @vindex __djgpp_stack_overflow_eip
> > @findex __djgpp_stack_overflow_exit
> > @subheading Syntax
> >
> > @example
> > unsigned int __djgpp_stack_overflow_eip;
>
> I think you need an "extern":
>
>     extern unsigned int __djgpp_stack_overflow_eip;

Yes.

> > void __djgpp_stack_overflow_exit(void);
> > @end example
> >
> > @subheading Description
> >
> > This is the stack overflow handler, intended to be used only by
> > compiler-generated code.
>
> How about this?
>
> "This is the stack overflow handler, an internal function intended to be used
> only by special code generated by the compiler."

Yes, that's better.

> > This will exit with suitable error message.
> [snip]
>
> "suitable error message" -> "a suitable error message"?

Yes.

> > ===================================================================
> > RCS file: /cvs/djgpp/djgpp/src/docs/kb/wc204.txi,v
> > retrieving revision 1.162
> > diff -c -r1.162 wc204.txi
> > *** wc204.txi   8 Nov 2003 12:19:40 -0000       1.162
> > --- wc204.txi   10 Nov 2003 11:52:10 -0000
> > ***************
> > *** 1032,1034 ****
> > --- 1032,1038 ----
> >   @code{strftime} now uses the date format (for @code{%x})
> >   and time format (for @code{%X}) from the current locale.
> >   This means that @code{%T} and @code{%X} are no longer equivalent.
> > +
> > + @vindex __djgpp_stack_overflow_eip AT r{ added}
> > + @findex __djgpp_stack_overflow_exit AT r{ added}
> > + The stack overflow handler was added.
>
> "The" -> "A"?

"A handler was added" makes me think that we may add another one some
day, but English is not my native language, so I'll trust your opinion.

-- 
Esa Peuha
student of mathematics at the University of Helsinki
http://www.helsinki.fi/~peuha/