X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3FAFEC80.E3DF81F8@phekda.freeserve.co.uk>
Date: Mon, 10 Nov 2003 19:52:32 +0000
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: djgpp-workers AT delorie DOT com
Subject: Re: djgpp: djgpp/src/libc/go32/makefile,overflow.S
References: <200311070952 DOT hA79qp0D028636 AT delorie DOT com> <3FACDD1E DOT 4950D38B AT phekda DOT freeserve DOT co DOT uk> <Pine DOT OSF DOT 4 DOT 58 DOT 0311101328470 DOT 17387 AT sirppi DOT helsinki DOT fi>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

Esa A E Peuha wrote:
> 
> On Sat, 8 Nov 2003, Richard Dawe wrote:
> 
> > Could you put some text at the start of this file, explaining what
> > its purpose is, please?
> 
> Would it be enough to describe this in overflow.txh instead?  Something
> like this:

Yes, that looks good. I have some small suggestions. See below.

> @c ----------------------------------------------------------------------
> @node Stack overflow handler, signal
> @vindex __djgpp_stack_overflow_eip
> @findex __djgpp_stack_overflow_exit
> @subheading Syntax
> 
> @example
> unsigned int __djgpp_stack_overflow_eip;

I think you need an "extern":

    extern unsigned int __djgpp_stack_overflow_eip;

> void __djgpp_stack_overflow_exit(void);
> @end example
> 
> @subheading Description
> 
> This is the stack overflow handler, intended to be used only by
> compiler-generated code.

How about this?

"This is the stack overflow handler, an internal function intended to be used
only by special code generated by the compiler."

> This will exit with suitable error message.
[snip]

"suitable error message" -> "a suitable error message"?

> ===================================================================
> RCS file: /cvs/djgpp/djgpp/src/docs/kb/wc204.txi,v
> retrieving revision 1.162
> diff -c -r1.162 wc204.txi
> *** wc204.txi   8 Nov 2003 12:19:40 -0000       1.162
> --- wc204.txi   10 Nov 2003 11:52:10 -0000
> ***************
> *** 1032,1034 ****
> --- 1032,1038 ----
>   @code{strftime} now uses the date format (for @code{%x})
>   and time format (for @code{%X}) from the current locale.
>   This means that @code{%T} and @code{%X} are no longer equivalent.
> +
> + @vindex __djgpp_stack_overflow_eip AT r{ added}
> + @findex __djgpp_stack_overflow_exit AT r{ added}
> + The stack overflow handler was added.

"The" -> "A"?

Thanks, bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]

"You can't evaluate a man by logic alone." -- McCoy, "I, Mudd", Star Trek