X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f From: Kbwms AT aol DOT com Message-ID: <1ef.12e638bb.2cdfbbb3@aol.com> Date: Sun, 9 Nov 2003 10:48:03 EST Subject: Re: Why don't we use -Wall in CFLAGS in Cygnus tests? To: djgpp-workers AT delorie DOT com MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="part1_1ef.12e638bb.2cdfbbb3_boundary" X-Mailer: 8.0 for Windows sub 6021 Reply-To: djgpp-workers AT delorie DOT com --part1_1ef.12e638bb.2cdfbbb3_boundary Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Rich Dawe: In a message dated 11/9/2003 5:31:25 AM Eastern Standard Time, rich AT phekda DOT freeserve DOT co DOT uk writes: > Why don't we use -Wall in CFLAGS in Cygnus tests? > > Building with -Wall shows a bunch of warnings that we should fix. E.g. > "abort" > not prototyped, because wasn't included in test_is.c. > > This response refers to the makefile in ../tests/cygnus directory dated 7/29/1999 from djtst203.zip. Putting -Wall in CFLAGS evidently doesn't do the trick except for files from subdirectory tgen. At line 33, I added -Wall, thusly: CFLAGS = $(DEFS) -O2 -g -Wall That ferreted out compiler warnings in files generated from the tgen directory. Eli was instrumental in finding the problem and fixing it. This effort began on 8/7/2003; it took nearly a week to solve the problem. I thought that would do it, but there is a gotcha in the makefile (got me, anyway). At line 89: $(OFILES): CFLAGS = $(DEFS) -fno-builtin -O2 -g The original setting of CFLAGS becomes $(DEFS) -fno-builtin -O2 -g. OFILES is defined on line 36 and 37: OFILES = test.o string.o convert.o conv_vec.o iconv_vec.o test_is.o \ dvec.o sprint_vec.o sprint_ivec.o math.o math2.o test_ieee.o KB Williams --part1_1ef.12e638bb.2cdfbbb3_boundary Content-Type: text/html; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Rich Dawe:

In a message dated 11/9/2003 5:31:25 AM Eastern Standard Time, rich AT phekda DOT f= reeserve.co.uk writes:

Why don't we use -Wall in CFLAGS in Cygnus tests?

Building with -Wall shows a bunch of warnings that we should fix. E.g. "abor= t"
not prototyped, because <stdlib.h> wasn't included in test_is.c.



This response refers to the makefile in ../tests/cygnus directory dated 7/29= /1999 from djtst203.zip.

Putting -Wall in CFLAGS evidently doesn't do the trick except for files from= subdirectory tgen.  At line 33, I added -Wall, thusly:

CFLAGS   =3D $(DEFS) -O2 -g -Wall

That ferreted out compiler warnings in files generated from the tgen directo= ry.  Eli was instrumental in finding the problem and fixing it.  T= his effort began on 8/7/2003; it took nearly a week to solve the problem.
I thought that would do it, but there is a gotcha in the makefile (got me, a= nyway).  At line 89:

$(OFILES): CFLAGS =3D $(DEFS) -fno-builtin -O2 -g

The original setting of CFLAGS becomes $(DEFS) -fno-builtin -O2 -g.  OFILES is defined on line 36 and 37:

OFILES =3D test.o string.o convert.o conv_vec.o iconv_vec.o test_is.o \
            &nbs= p;     dvec.o sprint_vec.o sprint_ivec.o math.o math2.o=20= test_ieee.o


KB Williams --part1_1ef.12e638bb.2cdfbbb3_boundary--