X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f Sender: rich AT phekda DOT freeserve DOT co DOT uk Message-ID: <3F9EC775.41795CD0@phekda.freeserve.co.uk> Date: Tue, 28 Oct 2003 19:45:57 +0000 From: Richard Dawe X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586) X-Accept-Language: de,fr MIME-Version: 1.0 To: djgpp-workers AT delorie DOT com Subject: Re: locale fixes References: <3F9E3836 DOT 000008 DOT 02793 AT soapbox DOT yandex DOT ru> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: djgpp-workers AT delorie DOT com Hello. Alexander Aganichev wrote: > I've splitted the patchset to the separate fixes. I hope it would be easier > to review (and accept :)) them separately. After the previous patches will > be accepted there are two major changes will need to be done: global > changes in regex which will make library non-ASCII friendly and replacing > of setlocale() implementation. [snip] Yes, the split patches are much easier to review. Thanks for doing that. I don't have time to review them properly, but they basically look OK to me. I'll review them properly on Sunday, hopefully. Do you have any test programs for these functions? If there are any existing tests, do they still pass, after applying your patches? Thanks, bye, Rich =] -- Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ] "You can't evaluate a man by logic alone." -- McCoy, "I, Mudd", Star Trek