From: sandmann AT clio DOT rice DOT edu (Charles Sandmann) Message-Id: <10305120346.AA12303@clio.rice.edu> Subject: Re: DXE3 in DJGPP CVS breaks cross-compiling To: eliz AT elta DOT co DOT il Date: Sun, 11 May 2003 22:46:08 -0500 (CDT) Cc: djgpp-workers AT delorie DOT com, dborca AT yahoo DOT com In-Reply-To: <9743-Mon12May2003063026+0300-eliz@elta.co.il> from "Eli Zaretskii" at May 12, 2003 06:30:27 AM X-Mailer: ELM [version 2.5 PL2] Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: djgpp-workers AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: djgpp-workers AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk > > > To remedy this, we need to quote every arg that needs it (or maybe > > > just quote all of them). > > > > I'd prefer not. The old code didn't. > > The old code used spawn* which doesn't require such characters to be > quoted. spawn* functions already know that each arcg they get is a > single string, so any special characters there don't matter. The original dxegen code used system, didn't quote, and was compatible with non-DJGPP platforms. The new dxe3gen code uses spawn, which is NOT compatible for cross compiles. I'm willing to either make it cross compile compatible with a quick conversion to system, or leave it as it is with spawn and then we just don't support cross builds. > > If we really require that, then maybe we don't need to have cross > > compile support and should leave it the way it is. > > An alternative would be to rewrite the portability layer for spawn* > that uses exec*, not `system'. exec* and spawn* share the wayt hey > treat their arguments: they both don't require quoting. Feel free to do so, but it's not in the library right now, and I don't have time to do it and test it.