Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3E761AC6.596197DC@phekda.freeserve.co.uk>
Date: Mon, 17 Mar 2003 18:58:14 +0000
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: djgpp-workers AT delorie DOT com
Subject: Re: strto{d,f,ld}, inf and nan patch
References: <200303171809 DOT h2HI96l03601 AT speedy DOT ludd DOT luth DOT se>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

ams AT ludd DOT luth DOT se wrote:
> 
> According to Richard Dawe:
> > The diff didn't seem to include src/libc/c99/math/nan.c.
> 
> Oops. It's easy to miss them while they've not been cvs added yet. Now
> we get a test case as well...

FWIW here's how I make a patch. Create a file called foo-files.txt, which
contains a list of all the files involved in the patch - even if they're not
in CVS. "foo" describes the patch in some way, e.g. pwrite & pwrite-files.txt.
Then to make the patch:

cat foo-files.txt \
    | grep -v -E '(bar|baz)' \
    | xargs -n 2 cvsw diff -pc3 > foo-nnnnnnnn.diff

cat foo-files.txt \
    | grep -E '(bar|baz)' \
    | xargs -n 1 diff -pc3N /dev/null >> foo-nnnnnnnn.diff

cvsw is a script that I use that calls a Windows CVS binary. "bar" and "baz"
are strings that identify the new files, e.g. "pwrite". nnnnnnnn is the date
in ISO-8061 format (e.g.: 20030317).

> Richard shouldn't there be some copyright on the test cases in
> tests/libc/c99/?
[snip]

Probably. Lots of the tests don't have copyright messages, though. I'm happy
with them being GPL'd. I'm sure I remember DJ sayign something about them
being GPL'd before.

The patch looks fine to me.

Bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]