Date: Fri, 07 Mar 2003 22:40:00 +0200
From: "Eli Zaretskii" <eliz AT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: rich AT phekda DOT freeserve DOT co DOT uk
Message-Id: <5567-Fri07Mar2003224000+0200-eliz@elta.co.il>
X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 1.8.9
CC: djgpp-workers AT delorie DOT com
In-reply-to: <E18rL7f-0000vZ-00@phekda.freeserve.co.uk>
	(rich AT phekda DOT freeserve DOT co DOT uk)
Subject: Re: _write_fill_seek_gap: Bug in checking for non-files [PATCH]
References:  <E18rL7f-0000vZ-00 AT phekda DOT freeserve DOT co DOT uk>
Reply-To: Eli Zaretskii <eliz AT elta DOT co DOT il>
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Fri, 07 Mar 2003 16:57:59 +0000
> From: "Richard Dawe" <rich AT phekda DOT freeserve DOT co DOT uk>
> 
> There's a bug in _write_fill_seek_gap that prevents the zero-fill
> from working for files with file descriptors that bits 0-2 set.
> The code is trying to avoid zero-fill for character devices,
> where it's not applicable. But it does not check that the device info
> has the character device bit set (_DEV_CDEV == 0x80).
> 
> Below is a patch that fixes this problem. OK to commit?

Looks fine to me.  Thanks.