Message-ID: <3E676811.4A5E1C0B@yahoo.com>
Date: Thu, 06 Mar 2003 10:24:01 -0500
From: CBFalconer <cbfalconer AT yahoo DOT com>
Organization: Ched Research
X-Mailer: Mozilla 4.75 [en] (Win98; U)
X-Accept-Language: en
MIME-Version: 1.0
To: djgpp-workers AT delorie DOT com
Subject: Re: New POSIX: _tolower, _toupper [PATCH]
References: <E18qtTk-0000VP-00 AT phekda DOT freeserve DOT co DOT uk> <Pine DOT OSF DOT 4 DOT 51 DOT 0303061402530 DOT 32514 AT sirppi DOT helsinki DOT fi>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Esa A E Peuha wrote:
> On Thu, 6 Mar 2003, Richard Dawe wrote:
> 
> > Below is a patch to add the _tolower and _toupper functions
> > required by new POSIX.
> >
> > OK to commit?
> [snip]
> > + @portability !ansi, posix
> 
> That line means that these functions are older POSIX, which they aren't.
> You'll have to use the longer form:
> 
> @portability !ansi-c89, !ansi-c99, !posix-1003.2-1992, posix-1003.1-2001

Surely !ansi suffices?  Which brings up the relative invisibility
of !.  This has bitten me before.  Wouldn't the use of NOT be more
obvious to the reader?

Another minor thought - the standard is really ISO, and ANSI is
somewhat parochial IMO.  Where things differ between C99 and
C89/C90/C94 it might be better to specify just the demarcation
line(s), eg: "!C94, C99, !posix-1992, posix-2001".

-- 
Chuck F (cbfalconer AT yahoo DOT com) (cbfalconer AT worldnet DOT att DOT net)
   Available for consulting/temporary embedded and systems.
   <http://cbfalconer.home.att.net>  USE worldnet address!