Sender: rich AT phekda DOT freeserve DOT co DOT uk Message-ID: <3E5D042C.10179331@phekda.freeserve.co.uk> Date: Wed, 26 Feb 2003 18:15:08 +0000 From: Richard Dawe X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586) X-Accept-Language: de,fr MIME-Version: 1.0 To: djgpp-workers AT delorie DOT com Subject: Re: fchmod, revision 3 [PATCH] References: <200302261504 DOT QAA11492 AT lws256 DOT lu DOT erisoft DOT se> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: djgpp-workers AT delorie DOT com Hello. Martin Stromberg wrote: [snip] > Shouldn't you check that that close() is successful? In case of > buffering or whatever you might not see any error until you close the > file. (There might be other close()s you need to check as well.) Yes, I've added three checks to the test program: two for close and one for _dos_close. I also fixed the return-value check for _dos_open, which was slightly wrong (according to the info page) - I was checking for < 0 rather than != 0. These changes did not affect the test result under Windows '98 SE or the DOS that comes with Windows '98 SE. Thanks, bye, Rich =] -- Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]