Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3E319B0C.D99F6005@phekda.freeserve.co.uk>
Date: Fri, 24 Jan 2003 19:59:08 +0000
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
CC: djgpp-workers AT delorie DOT com
Subject: Re: ssize_t: int -> signed long [PATCH]
References: <Pine DOT SUN DOT 3 DOT 91 DOT 1030123081522 DOT 15630C AT is> <3E2FB5F0 DOT B7FD75FC AT phekda DOT freeserve DOT co DOT uk> <1659-Thu23Jan2003203612+0200-eliz AT is DOT elta DOT co DOT il> <3E304571 DOT BFA087FF AT phekda DOT freeserve DOT co DOT uk> <3791-Fri24Jan2003214724+0200-eliz AT is DOT elta DOT co DOT il>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

Eli Zaretskii wrote:
> 
> > Date: Thu, 23 Jan 2003 19:41:37 +0000
> > From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
> > >
> > > No, we don't pollute stdio.h because it already includes sys/djtypes.h
> > > which defines ssize_t.
> >
> > I don't think <sys/djtypes.h> does actually pollute. It #defines something
> > which typedefs ssize_t.
> 
> Right, I overlooked that.
> 
> However, isn't ssize_t mandated by some standard?

Yes, POSIX or SUS. However, it's not defined in <stdio.h>. <stdio.h> is
allowed to define anything that <stddef.h> does. But ssize_t is not in
<stddef.h>. It's defined in <sys/types.h>

So we would pollute <stdio.h> with ssize_t, if FILE._cnt is an ssize_t. Shall
I revert FILE._cnt to a long?

> > > Perhaps we should change FSEXT to return an ssize_t.
> >
> > If we're going to change it, I would prefer a long long, since then it
> > will cope with return values from anything (llseek, etc.). But that's not
> > binarily compatible
> 
> It's also slower.
> 
> I think we should make it ssize_t.

OK. I'll submit a new patch with that change in, once the FILE._cnt issue is
resolved.

Thanks, bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]