Message-ID: <3E305DAB.8090607@mif.vu.lt> Date: Thu, 23 Jan 2003 22:24:59 +0100 From: Laurynas Biveinis Organization: VU MIF User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: lt, en, en-us MIME-Version: 1.0 To: djgpp-workers AT delorie DOT com, Richard Dawe Subject: Re: Take on __solve_symlinks() References: <3E286C07 DOT 7040200 AT mif DOT vu DOT lt> <3E2943DA DOT 523770FC AT phekda DOT freeserve DOT co DOT uk> <3E297258 DOT 50906 AT mif DOT vu DOT lt> <3E2A9396 DOT EF36FE73 AT phekda DOT freeserve DOT co DOT uk> In-Reply-To: <3E2A9396.EF36FE73@phekda.freeserve.co.uk> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 23 Jan 2003 20:23:06.0049 (UTC) FILETIME=[3CC02B10:01C2C31D] Reply-To: djgpp-workers AT delorie DOT com Richard Dawe wrote: >>No I don't, but I didn't see any failures, probably because we're >>running two different test programs - I've cleaned up the test program a >>bit. I'm attaching it. Could you tell if it fails with your testcases? > > > Which test cases? The ones I have described or the ones that failed? The ones you've described. > The test cases that failed are in the CVS xsymlink test. I haven't added any > test cases to that for a while. The tests that fail are the ones that take the > current directory, count the number of slashes (n_slashes) and then prepend > lots of ".."s to the path without the directory (cwd_without_drive). Uhm, I guess I have a problem with my setup here - these test cases don't fail for me. Maybe you have some piece of advice? sh-2.05b$ pwd c:/devel/djgpp/tests/libc/compat/unistd sh-2.05b$ ./xsymlink Running __solve_symlinks() and readlink() testsuite: Tests that check __solve_symlinks() works: Test 1 passed Test 2 passed Test 3 passed Test 4 passed Test 5 passed Test 6 passed Test 7 passed Test 8 passed Test 9 passed Test 10 passed Test 11 passed Test 12 passed Test 13 passed Tests that check __solve_symlinks() based on current directory: Test 1: Solving c:/devel/djgpp/tests/libc/compat/unistd/../../../../../../devel/djgpp/tests/libc/compat/unistd/test1 Test 1 passed Test 2: Solving c:../../../../../../devel/djgpp/tests/libc/compat/unistd/test1 Test 2 passed Test 3: Solving c:../../../../../../../devel/djgpp/tests/libc/compat/unistd/test1 Test 3 passed Tests that check __solve_symlinks() failure cases: Test 1 passed Test 2 passed PASS >>>* symlinks between drives; >> >>Will see, the problem is that not everybody has multiple drives... > > > Most computers have a floppy drive, don't they? So we will require user to insert blank formatted diskette into drive A:, won't we? Somehow it does not look reasonable for me :) -- Laurynas