X-Mailer: exmh version 2.0.2 To: Laurynas Biveinis cc: gcc-patches AT gcc DOT gnu DOT org, DJGPP Workers Subject: Re: Fixproto fix In-reply-to: Your message of Fri, 19 May 2000 08:55:22 +0300. <3924D74A DOT 352A36A6 AT softhome DOT net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 23 May 2000 23:49:35 -0600 Message-ID: <10288.959147375@upchuck> From: Jeffrey A Law Reply-To: djgpp-workers AT delorie DOT com In message <3924D74A DOT 352A36A6 AT softhome DOT net>you write: > Jeffrey A Law wrote: > > > * fixproto: Recognize DOS paths with drive letters as absolute pa > ths. > > This can't be correct since it will mess up on systems which allow direct > ory > > names like c; (ie every unix system I'm aware of). > > Sorry, I don't understand why patch is wrong. I've > > +case $rel_target_dir in > + /* | [A-Za-z]:[\\/]*) > + abs_target_dir=$rel_target_dir > > If you mean directory names like 'c;/foo', they will be corectly recognized > as relative - the patch checks for presence of ':', which is not allowed in > file names. My point is on a unix system ':' is an allowed file/directory name. Let me put it another way c:/blah is an absolute on a dos based filesystem, but relative on a unix based filesystem. Therefore code which unconditionally assumes that kind of path is absolute or relative is broken since the interpretation of that path is dependent on the host filesystem. jeff