MIME-Version: 1.0
In-Reply-To: <83wqeh9pwq.fsf@gnu.org>
References: <CAA2C=vBuWHmVNrRAcGDSXYLc8Eg_xsyMVszPzrxqHGrpVq2vmw AT mail DOT gmail DOT com>
	<83wqeh9pwq DOT fsf AT gnu DOT org>
Date: Tue, 22 Apr 2014 21:54:16 +0300
Message-ID: <CAA2C=vD_97x3-A0Y52JDfbmmFiuVzF_Ufub6imhmuhTsdsNr4w@mail.gmail.com>
Subject: Re: [PATCH] break xstat.c into pieces
From: Ozkan Sezer <sezeroz AT gmail DOT com>
To: djgpp-workers AT delorie DOT com
Content-Type: text/plain; charset=UTF-8
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
Precedence: bulk

On 4/22/14, Eli Zaretskii <eliz AT gnu DOT org> wrote:
>> Date: Tue, 22 Apr 2014 14:11:36 +0300
>> From: Ozkan Sezer <sezeroz AT gmail DOT com>
>>
>> The following patch breaks xstat.c into smaller pieces, so that, e.g.
>> mkdir() doesn't pull in unnecessary dependencies such as ctime.o.
>
> I'd rather change 'mkdir' so that it doesn't call 'access', but only
> its small subset that is needed for testing the D_OK flag.  That
> sounds like a smaller and more localized change to me.  WDYT?
>

Changing mkdir() is the first thing that conmes to mind, but there
is also _is_executable(), which is a public func through sys/stat.h,
an it relies on _djstat_flags which is in xstat.c at present.

I suggest that we chop xstat.c into pieces _and_ change mkdir() too.

A simple patch for mkdir() itself is inlined below. Note, however,
this eliminates the _fixpath() operation present in access(): I do
not know how necessary that is.

Index: mkdir.c
===================================================================
RCS file: /cvs/djgpp/djgpp/src/libc/posix/sys/stat/mkdir.c,v
retrieving revision 1.7
diff -u -p -r1.7 mkdir.c
--- mkdir.c	2 Oct 2011 02:40:11 -0000	1.7
+++ mkdir.c	22 Apr 2014 18:50:40 -0000
@@ -73,7 +73,8 @@ do_mkdir:
     {
       /* see if the directory existed, in which case
          we should return EEXIST - DJ */
-      if (access(mydirname, D_OK) == 0)
+      if ((attr = _chmod(dir_name, 0)) != -1 &&
+           attr & 0x10)
         errno = EEXIST;
       else
         errno = save_errno;

--
O.S.