X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient: djgpp-workers AT delorie DOT com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=r5Xmwno8QAosZwz5GYff8ludTts4P/U2SImnlnY8YuE=;
        b=OgJJPgmEAKiZpIgoxwj+p6WfiqfgzrAdtzBTjHQLc3b8jP5NO2JQlkBxk7Gcfg5021
         g1rrA0BDMzF8dFslyp5ZcI5ruWRIm2FFUJa/fbLlQ0+tUMo3puOgSyG0guIfinpOhQFy
         aBF72Z2Nxm0nn8FXzjp8VgV0ynSPk2U2/tFac=
MIME-Version: 1.0
In-Reply-To: <83ty9c453p.fsf@gnu.org>
References: <CAA2C=vCABbghMEVV2Hss+eXcmkFxuHA+dE6+Nc+-yzw-cHv1YA AT mail DOT gmail DOT com>
	<CAA2C=vBLXmFb9Pu7nmivBhiOGs=VghZ8f90CvcAk+ijV3+Cq+A AT mail DOT gmail DOT com>
	<CAA2C=vAjAgCxQqu1bJGE05Rbjd+6b7z_2xKZ=YHYfsKr5uKptQ AT mail DOT gmail DOT com>
	<83ty9c453p DOT fsf AT gnu DOT org>
Date: Sat, 20 Aug 2011 17:10:42 -0500
Message-ID: <CAA-ihx9cK=hixLEsdRO1W+1KwP0EyXa1WisanS8aPbsRkt0a1Q@mail.gmail.com>
Subject: Re: [PATCH] fix cabs and cabsf build failure with gcc-4.4, test results
From: Rugxulo <rugxulo AT gmail DOT com>
To: djgpp-workers AT delorie DOT com
Content-Type: text/plain; charset=ISO-8859-1
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Hi,

   I'm the worst person to comment on this, but ... if __STDC__ means
ANSI/ISO C89/C90/C99, then lacking that, K&R C won't have _Complex
(C99) keyword anyways. So I fail to see the point. As mentioned, DJ
says older compilers aren't worth supporting (e.g. GCC 2.95.3, which
allegedly only had very very minimal C99 support).


On 8/20/11, Eli Zaretskii <eliz AT gnu DOT org> wrote:
>
>  . I didn't remove the K&R prototypes, and instead modified them to
>    fit the STDC ones.
>
> The patch I committed appears below.  Please see if I didn't screw up
> anything.
>
>  #ifdef __STDC__
> -double cabs(struct complex);
> -double cabs(struct complex z)
> +double cabs(_Complex double);
> +double cabs(_Complex double z)
>  #else
>  double cabs(z)
> -     struct complex z;
> +     _Complex double z;
>  #endif
> ...
>  #ifdef __STDC__
> -float cabsf(struct complex);
> -float cabsf(struct complex z)
> +float cabsf(_Complex float);
> +float cabsf(_Complex float z)
>  #else
>  float cabsf(z)
> -	struct complex z;
> +	_Complex float z;
>  #endif