X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient: djgpp-workers AT delorie DOT com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        bh=X22e11kesPVL45Sbz6NDRLnOGFTUErFznXQEqr6+0JE=;
        b=QgkjHNFDYoCb7Wa/wGTRBO/vs81iwfUEaFOzd73F/oqDXvNv1B4KzmS4yYbbfhEZN+
         PngYCtJHA7/a5puf4pvq8tZhMB7czfg3JCSTEgdPo0y1wHNmT6r9l6yDwp3krYdh8LJO
         sKqNk9X5XmdjNjD+PsUtP8m60/XCKMhC8+JAs=
MIME-Version: 1.0
In-Reply-To: <201107021926.48563.juan.guerrero@gmx.de>
References: <BANLkTimnFhfjYM=HbSmv5v7KdCkKfVLrgQ AT mail DOT gmail DOT com>
	<201107021926 DOT 48563 DOT juan DOT guerrero AT gmx DOT de>
Date: Sat, 2 Jul 2011 20:40:48 +0300
Message-ID: <BANLkTi=f2bhVUio9R4Sb60LHB0Wb5-79YQ@mail.gmail.com>
Subject: Re: [patch] kill gets() usage in stubedit.c, use fgets()
From: Ozkan Sezer <sezeroz AT gmail DOT com>
To: djgpp-workers AT delorie DOT com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id p62Herew015851
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Sat, Jul 2, 2011 at 8:26 PM, Juan Manuel Guerrero
<juan DOT guerrero AT gmx DOT de> wrote:
> Am Samstag, 2. Juli 2011 schrieb Ozkan Sezer:
>> Compilation of stubedit.c warns:
>> /tmp/cc0xwkwD.o: In function `pose_question':
>> /djgpp-20110630/src/stub/stubedit.c:92: warning: the `gets' function
>> is dangerous and should not be used.
> [snip]
>
> Are there more cases where gets is used?  If so they should be fixed all
> together.
>

Quick scanning reveals:

src/utils/djtar/djtar.c: line #208:  Missed this because I never use
it, not needed in cross-tools

src/libc/dos/dir/fnsplit.c::main() line #119 (but that's only  TEST code,
not compiled into lib.)

> Regards,
> Juan M. guerrero
>

--
O.S.