X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient: djgpp-workers AT delorie DOT com
Date: Wed, 13 Aug 2008 13:21:53 +0300 (EEST)
From: Esa A E Peuha <peuha AT cc DOT helsinki DOT fi>
Sender: peuha AT ruuvi DOT it DOT helsinki DOT fi
To: djgpp-workers AT delorie DOT com
Subject: Re: Scope of _ioctl_get_first_cluster().
In-Reply-To: <200806251911.45534.juan.guerrero@gmx.de>
Message-ID: <Pine.LNX.4.64L.0808131319580.14023@ruuvi.it.helsinki.fi>
References: <200806251911 DOT 45534 DOT juan DOT guerrero AT gmx DOT de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Wed, 25 Jun 2008, Juan Manuel Guerrero wrote:

> In lstat.c _ioctl_get_first_cluster() is defined but not as static function.
> It is a helper function called by stat_assist() but by no other function in libc.
> Is it intentional that _ioctl_get_first_cluster() has global scope?
> Should not it be local?

Yes; if anything else ever needs it, it should be moved to its own file
anyway.  I've committed a patch to make it static.

-- 
Esa Peuha
student of mathematics at the University of Helsinki
http://www.helsinki.fi/~peuha/