X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
To: Eli Zaretskii <eliz AT gnu DOT org>
Cc: djgpp-workers AT delorie DOT com, gcc-patches AT gcc DOT gnu DOT org,
   gdb-patches AT sourceware DOT org
Subject: Re: RFA: fix libiberty/pex-djgpp.c
References: <01c5565c$Blat.v2.4$082130a0 AT zahav DOT net DOT il>
	<m3y8alqzgx DOT fsf AT gossamer DOT airs DOT com>
	<01c55680$Blat.v2.4$9ebe4740 AT zahav DOT net DOT il>
From: Ian Lance Taylor <ian AT airs DOT com>
Date: 11 May 2005 22:17:43 -0400
In-Reply-To: <01c55680$Blat.v2.4$9ebe4740@zahav.net.il>
Message-ID: <m38y2lqjaw.fsf@gossamer.airs.com>
Lines: 29
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

"Eli Zaretskii" <eliz AT gnu DOT org> writes:

> > Cc: gcc-patches AT gcc DOT gnu DOT org, gdb-patches AT sourceware DOT org,
> >    djgpp-workers AT delorie DOT com
> > From: Ian Lance Taylor <ian AT airs DOT com>
> > Date: 11 May 2005 16:28:30 -0400
> > 
> > You don't need pex_djgpp_fdopenr.  It will only be called if
> > pex_init_common is called with PEX_USE_PIPES
> 
> It's not easy to figure out what is needed and in what conditions.  It
> would be nice if this machinery were to be documented a bit more
> methodically.  Right now, the information is scattered between
> pex-common.h, include/libiberty.h and a few comments in pex-*.c files.

Don't forget pexecute.txh.

It's true that I did not bother to fully document the internals.  I
don't anticipate that very many people will be writing new pex-*.c
files.

> > Otherwise, this patch is approved.  Please check it into the gcc
> > repository first, as usual with libiberty patches.
> 
> I don't think I have write access to the GCC repository, sorry.

I will check it in soon, then.  Thanks.

Ian