X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
Date: Thu, 12 May 2005 02:23:44 +0300
From: "Eli Zaretskii" <eliz AT gnu DOT org>
Sender: halo1 AT zahav DOT net DOT il
To: djgpp-workers AT delorie DOT com
Message-ID: <01c55680$Blat.v2.4$9ebe4740@zahav.net.il>
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=ISO-8859-1
X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4
CC: gcc-patches AT gcc DOT gnu DOT org, gdb-patches AT sourceware DOT org
In-reply-to: <m3y8alqzgx.fsf@gossamer.airs.com> (message from Ian Lance Taylor
	on 11 May 2005 16:28:30 -0400)
Subject: Re: RFA: fix libiberty/pex-djgpp.c
References: <01c5565c$Blat.v2.4$082130a0 AT zahav DOT net DOT il> <m3y8alqzgx DOT fsf AT gossamer DOT airs DOT com>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Cc: gcc-patches AT gcc DOT gnu DOT org, gdb-patches AT sourceware DOT org,
>    djgpp-workers AT delorie DOT com
> From: Ian Lance Taylor <ian AT airs DOT com>
> Date: 11 May 2005 16:28:30 -0400
> 
> You don't need pex_djgpp_fdopenr.  It will only be called if
> pex_init_common is called with PEX_USE_PIPES

It's not easy to figure out what is needed and in what conditions.  It
would be nice if this machinery were to be documented a bit more
methodically.  Right now, the information is scattered between
pex-common.h, include/libiberty.h and a few comments in pex-*.c files.

> Otherwise, this patch is approved.  Please check it into the gcc
> repository first, as usual with libiberty patches.

I don't think I have write access to the GCC repository, sorry.

Anyway, thanks for a timely review.