X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
To: Eli Zaretskii <eliz AT gnu DOT org>
Cc: gcc-patches AT gcc DOT gnu DOT org, gdb-patches AT sourceware DOT org,
   djgpp-workers AT delorie DOT com
Subject: Re: RFA: fix libiberty/pex-djgpp.c
References: <01c5565c$Blat.v2.4$082130a0 AT zahav DOT net DOT il>
From: Ian Lance Taylor <ian AT airs DOT com>
Date: 11 May 2005 16:28:30 -0400
In-Reply-To: <01c5565c$Blat.v2.4$082130a0@zahav.net.il>
Message-ID: <m3y8alqzgx.fsf@gossamer.airs.com>
Lines: 18
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

"Eli Zaretskii" <eliz AT gnu DOT org> writes:

> The current CVS version of pex-djgpp.c didn't compile.  The patch
> below fixes the problems I spotted; please review it.

Thanks for doing this.  I did not have a DJGPP system to try this code
out on.  It was obviously in fairly bad shape.

You don't need pex_djgpp_fdopenr.  It will only be called if
pex_init_common is called with PEX_USE_PIPES, which should never
happen since pex_init in pex-djgpp.c clears PEX_USE_PIPES.

Otherwise, this patch is approved.  Please check it into the gcc
repository first, as usual with libiberty patches.

Thanks.

Ian