X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
Date: Fri, 07 Jan 2005 15:15:14 +0200
From: "Eli Zaretskii" <eliz AT gnu DOT org>
Sender: halo1 AT zahav DOT net DOT il
To: djgpp-workers AT delorie DOT com
Message-ID: <01c4f4bb$Blat.v2.2.2$12c86080@zahav.net.il>
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=ISO-8859-1
X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 2.2.2
In-reply-to: <b1jrt0p85v7491rjjr7u645822tpglci0v@4ax.com> (message from Brian
	Inglis on Thu, 06 Jan 2005 16:45:35 -0700)
Subject: Re: *time_r patch
References: <bcppt01o8hrjnj92qu6rbdq91s74aauird AT 4ax DOT com>
 <01c4f43c$Blat.v2.2.2$620c39c0 AT zahav DOT net DOT il> <b1jrt0p85v7491rjjr7u645822tpglci0v AT 4ax DOT com>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Thu, 06 Jan 2005 16:45:35 -0700
> From: Brian Inglis <Brian DOT Inglis AT SystematicSw DOT ab DOT ca>
> 
> Please see revised patch below.

Thanks.

I have a few minor comments:

> +@xref{ctime_r} for an alternate interface that allows the caller
> +to provide a buffer to receive the string.

You need to put some punctuation, usually a comma or a period, after
"@xref{ctime_r}" (makeinfo should have complained about that).  (There
are more xref's that lack such a punctuation, please fix them all.)

Also, I think "to store the string" is better than "to receive the
string", because the previous text says that the string is stored in a
static buffer.

> +to provide a buffer to receive the string.

Same here.

> +The structure pointed to is static and will be overwritten with
> +each call to gmtime.

"gmtime" is a C identifier, so it needs to be in @code{}.  (There are
a few other sentences like this one where the function name is not in
@code{}.)