X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
From: <ams AT ludd DOT ltu DOT se>
Message-Id: <200412301834.iBUIYugk012214@speedy.ludd.ltu.se>
Subject: Re: strftime patch
In-Reply-To: <8ot7t0pskgfe03p1ii3l2gfvr0guvc0plf@4ax.com> "from Brian Inglis
 at Dec 30, 2004 05:52:27 am"
To: djgpp-workers AT delorie DOT com
Date: Thu, 30 Dec 2004 19:34:55 +0100 (CET)
X-Mailer: ELM [version 2.4ME+ PL78 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-ltu-MailScanner-Information: Please contact the ISP for more information
X-ltu-MailScanner: Found to be clean
X-MailScanner-From: ams AT ludd DOT ltu DOT se
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

According to Brian Inglis:
> On Thu, 30 Dec 2004 13:03:13 +0100 (CET), ams AT ludd DOT ltu DOT se wrote:
> 
> >I'm getting failures from the strftim* test programs. OS WINDOWS 98
> >English, Swedish "Regional settings". djtz*.zip NOT installed. No
> >(what I think is) relevant environment variables set (LANG, LC_ALL,
> >TZ).
> >
> >My (lack of) setup might very well why it fails, but if something
> >are necessary for correct functioning the program should verify that.
> >
> >strftime:
> > fmt: "%Z "  expected: "GMT" 
> >                  got: "" 
> >
> > fmt: "%z "  expected: "+0000" 
> >                  got: "" 
> 
> Should work correctly as putenv(unconst("TZ=GMT0",char*) used! 
> Myabe should add putenv()/getenv() test comparison or switch to using
> setenv() as below? 

If it's supposed to do the right thing, it's probably me that needs to
debug it here where I have the problem.

> >strftimt:
> > test  10  error FAILED  expected '2000-01-05 17:41:01 UTC' 
> >                           actual '2000-01-05 17:41:01 ' 
> >
> > test  11  error FAILED  expected '2000-01-05 17:41:01 +0000' 
> >                           actual '2000-01-05 17:41:01 ' 
> >
> > test  32  error FAILED  expected '01.08.2000 05:06:07 CEST' 
> >                           actual '01.08.2000 05:06:07 EDT' 
> >
> > test  33  error FAILED  expected '01.08.2000 05:06:07 +0200' 
> >                           actual '01.08.2000 05:06:07 -0400' 
> >tests 33  errors     4  passed 29 
> 
> These tests currently assume tz files installed, could change to using
> TZ variable as in strftime test program and strftimt test 31. 

No, because this tests with tz files. It's not bad to have such a test
too. Perhaps we should have two? One like today and one using TZ?

> Could try patching strftime test program to use setenv() instead of
> putenv() and specify normal TZ env vars in strftimt. 

Possible. Or I can unzip djtz*.zip.


If someone wants/needs my recompiled libc or the current source I
have (remember, I had to manually apply some patches), I could zip it
up and put it up for download. Specify what exactly you want in that
case.


Right,

						MartinS