X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
From: "Juan Manuel Guerrero" <st001906 AT hrz1 DOT hrz DOT tu-darmstadt DOT de>
Organization: Darmstadt University of Technology
To: djgpp-workers AT delorie DOT com
Date: Wed, 08 Dec 2004 17:11:40 +0200
MIME-Version: 1.0
Subject: Re: A fix for popen()
Message-ID: <41B735CC.30919.DACE23@localhost>
In-reply-to: <Pine.OSF.4.58.0412081042170.1168@sirppi.helsinki.fi>
References: <41B5E51B DOT 9304 DOT 37DF4A0 AT localhost>
X-mailer: Pegasus Mail for Windows (4.21c, DE v4.21c R1)
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Mail message body
X-TUD-HRZ-MailScanner: Found to be clean
X-MailScanner-From: st001906 AT hrz1 DOT hrz DOT tu-darmstadt DOT de
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Wed, 8 Dec 2004, Esa A E Peuha wrote:
> > The important issue here is the to notice that the patch proposed by Esa
> > this morning still does not resolve the complete issue. The patch inhibits
> > the call to free() in pclose but left the same malign code:
> >  error:
> >
> >   if (l1->command)
> >     free(l1->command);
> >
> >   if (temp_name)
> >     free(temp_name);
> >
> > in popen().
> 
> Did you actually see crashes from freeing temp_name?  I don't see how
> that could happen, since temp_name will be initialized in any case.
> However, freeing the command pointer is completely unnecessary (read
> mode doesn't allocate it, write mode jumps there only when it's already
> null), so I removed it.

To clarify the issue:
1) The last patch you have submitted is OK. Now we have a working popen() and pclose().
2) temp_name does *not* generate any crash. Those lines with temp_name are only
part of the context I have printed. The issue is exclusivly the *comannd pointer, anything
else should not be modified.

Thanks for fixeing all this. Now I can submite working versions of texinfo 4.7 and sed-4.1.2

Regards,
Juan Manuel Guerrero