Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3EBD1FD2.4335B4F@phekda.freeserve.co.uk>
Date: Sat, 10 May 2003 16:50:42 +0100
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: djgpp-workers AT delorie DOT com
Subject: Re: djtar and slightly weirdly formatted ZIPs, revision 2 [PATCH]
References: <E19Bvwx-0000zi-00 AT phekda DOT freeserve DOT co DOT uk> <Pine DOT OSF DOT 4 DOT 51 DOT 0305061421140 DOT 24402 AT sirppi DOT helsinki DOT fi>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

Esa A E Peuha wrote:
> 
> On Sat, 3 May 2003, Richard Dawe wrote:
> 
> > !       fprintf(log_out,
> > !               "%s: don't understand header type 0x%x%x\n",
> > !               zipfilename, ((char *)&buffer)[0], ((char *)&buffer)[1]);
> 
> These bytes should be printed with "%02x", not "%x" (else 0x0f0f will be
> printed as 0xff), and the casts should be to unsigned char * (otherwise
> 0x8080 turns to 0xffffff80ffffff80).  The rest of the code seems fine.

Thanks for catching that. I committed the patch with that change.

Thanks, bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]