Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3E05D780.5F779C84@phekda.freeserve.co.uk>
Date: Sun, 22 Dec 2002 15:17:20 +0000
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: DJGPP workers <djgpp-workers AT delorie DOT com>
Subject: Re: djgpp: djgpp/src/libc/compat/unistd/_irdlink.c
References: <200212212318 DOT gBLNIFN03418 AT delorie DOT com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

"cvs-sandmann AT delorie DOT com" wrote:
> 
> Update by cvs id: sandmann
> Update of /cvs/djgpp/djgpp/src/libc/compat/unistd
> 
> Modified Files:
>         _irdlink.c
> Log Message:
> Image size reductions (call _read instead of read).
> 
> ===================================================================
> RCS file: /cvs/djgpp/djgpp/src/libc/compat/unistd/_irdlink.c,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -p -2 -r1.5 -r1.6
> *** djgpp/src/libc/compat/unistd/_irdlink.c     14 Jun 2002 14:24:30 -0000      1.5
> --- djgpp/src/libc/compat/unistd/_irdlink.c     21 Dec 2002 23:18:12 -0000      1.6
> *************** int __internal_readlink(const char * __p
> *** 99,103 ****
>      }
> 
> !    bytes_read = read(fd, &buf, _SYMLINK_FILE_LEN);
> 
>      if (__fhandle)
> --- 99,103 ----
>      }
> 
> !    bytes_read = _read(fd, &buf, _SYMLINK_FILE_LEN);
> 
>      if (__fhandle)

Are you sure this doesn't break symlinks? Symlinks are text files with
newlines, so don't we need read rather than _read, to convert CRLFs to
newlines? I would check this, but I don't want to do a 'cvs update', until
I've hunted down some other bugs.

Bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]