Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3DF76640.E81C4739@phekda.freeserve.co.uk>
Date: Wed, 11 Dec 2002 16:22:24 +0000
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.23 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: djgpp-workers AT delorie DOT com
Subject: Re: <inttypes.h> (C99) [PATCH]
References: <E18Lmjh-00014N-00 AT phekda DOT freeserve DOT co DOT uk> <1438-Tue10Dec2002224135+0200-eliz AT is DOT elta DOT co DOT il>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

Eli Zaretskii wrote:
> 
> Richard Dawe wrote:
[snip]
> > --- 794,811 ----
> >
> >   @findex _doprnt AT r{, and }hh AT r{ conversion qualifier}
> >   @findex printf AT r{, and }hh AT r{ conversion qualifier}
> > ! @findex _doscan AT r{, and }hh AT r{ conversion qualifier}
> > ! @findex scanf AT r{, and }hh AT r{ conversion qualifier}
> > ! The @code{hh} conversion qualifier is now supported by @code{_doprnt},
> > ! @code{_doscan}, the @code{printf} family of functions
> > ! and the @code{scanf} family of functions.
> 
> This part belongs to another patch, it seems.

Yes, this is from the 'hh' type conversion patch for scanf. A little manual
patching will be needed for src/docs/wc204.txi, if you apply the <inttypes.h>
patch on top of the scanf patch.

> > + intmax_t imaxabs (intmax_t x);
> > + @end example
> > +
> > + @subheading Description
> > +
> > + This function takes the absolute value of @var{x}.  @xref{abs}.
> 
> Shouldn't we explain why do we need another function that does what
> `abs' does?

OK.
 
> > + @subheading Return Value
> > +
> > + |@var{x}|
> 
> I'd suggest @code{|@var{x}|} instead, it will look better in print.

OK.
 
> > + @item PRIoFASTN
> > + @itemx PRIuFASTN
> > + @itemx PRIxFASTN
> > + @itemx PRIXFASTN
> > +
> > + The @code{o}, @code{u}, @code{x} and @code{X} type conversion specifiers
> > + for a type @code{uint_FASTN_t} of N bits.
> 
> I suggest to use @var{N} in both @item's and the text below them.  N
> stands for a number here, right?

Yes. I'll fix them.
 
> Finally, there are a few places where there's only one blank after a
> period that ends a sentence, instead of two blanks.

OK.

Thanks!

Bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]