X-Authentication-Warning: delorie.com: mailnull set sender to djgpp-workers-bounces using -f
Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3CB9AE31.D981C083@phekda.freeserve.co.uk>
Date: Sun, 14 Apr 2002 17:28:33 +0100
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.19 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: djgpp-workers AT delorie DOT com
Subject: Re: Patch: fchown()
References: <Pine DOT SUN DOT 3 DOT 91 DOT 1000119115250 DOT 9609S-100000 AT is> <3885B091 DOT 2A75187C AT softhome DOT net> <3CAD96E3 DOT 586DBA4A AT phekda DOT freeserve DOT co DOT uk> <9003-Fri05Apr2002184824+0300-eliz AT is DOT elta DOT co DOT il> <3CB7E2B4 DOT 9A956584 AT phekda DOT freeserve DOT co DOT uk> <5832-Sat13Apr2002121327+0300-eliz AT is DOT elta DOT co DOT il>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

Eli Zaretskii wrote:
[snip]
> I have some minor comments.
> 
>   - fchown.txh needs at least to say what this function does in
>     general.  Otherwise, people who want to implement the
>     functionality via FSEXT will not know what code to write.

This criticism applies to the chown info page. See another mail for a fix.

>   - since fchown is a trivial implementation, we should add it to the
>     menu in libc.tex.

Done.
 
>   - fsext.txh says the fchown handler is called ``when file
>     attributes are changed for an open file.''  I think you should
>     replace ``attributes'' with ``ownership.''

See another mail for a fix.

>   - wc204.txi talks about fchmod instead of fchown.

Oops, thanks!
 
> Thanks again for working on this (and to Laurinas for coding it in
> the first place).

Thanks for the corrections! Bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]