X-Authentication-Warning: delorie.com: mailnull set sender to djgpp-workers-bounces using -f
From: sandmann AT clio DOT rice DOT edu (Charles Sandmann)
Message-Id: <10201101553.AA19444@clio.rice.edu>
Subject: Re: LFN32 optimizations [was:  Re: Proposed lstat.c patch for Win2000/XP device bit fix
To: ams AT ludd DOT luth DOT se (Martin Str|mberg)
Date: Thu, 10 Jan 2002 09:53:14 -0600 (CST)
Cc: djgpp-workers AT delorie DOT com (DJGPP developers)
In-Reply-To: <200201100507.GAA25855@father.ludd.luth.se> from "Martin Str|mberg" at Jan 10, 2002 06:07:58 AM
X-Mailer: ELM [version 2.5 PL2]
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Make the last part "*(short *)(&(ff_blk.lfn_magic[4])) == '2'+(0<<8)"
> so we check the nul explicitly for the expressiveness.

Okay.

> Perhaps this macro should be called "_is_ff_LFN32", in case we would
> need a _is_ff_LFN macro sometime.

There is actually no difference, the LFN32 is just part of the 
signature block set in findfirs.c - it could be any string (as long
as it's consistent everywhere).  Changing the name would actually be
more confusing.

> Then I wonder why you're looking for LFN32 and not LFN? Is it only on
> FAT32 this bug exists?

The problem only occurs on Windows 2000/XP with LFN (which is why I'm
checking the block to see if the findfirst results were LFN'ed).  FAT32
doesn't have anything to do with it - 'LFN32' is just the string chosen
for the magic.  It is the "flag" which indicates that the atime and ctime
values are meaningful.  If not for backward compatibility I'd say using
a single long "LFN"+char(0) would be adequate in the magic.