X-Authentication-Warning: delorie.com: mailnull set sender to djgpp-workers-bounces using -f
From: Martin Str|mberg <ams AT ludd DOT luth DOT se>
Message-Id: <200201100459.FAA25834@father.ludd.luth.se>
Subject: Re: Proposed lstat.c patch for Win2000/XP device bit fix
In-Reply-To: <10201100020.AA19380@clio.rice.edu> from Charles Sandmann at "Jan 9, 2002 06:20:54 pm"
To: djgpp-workers AT delorie DOT com
Date: Thu, 10 Jan 2002 05:59:04 +0100 (MET)
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

According to Charles Sandmann:
> It's certainly more efficient (but shouldn't it just be '2' for the 
> second compare?) - if everyone agrees I'll make it a macro and use it
> twice in the code.  
> 
> > -  if ( ! strcmp(ff_blk.lfn_magic,"LFN32") )
> > +  if ( *(long *)(&(ff_blk.lfn_magic[0])) == 'L'+('F'<<8)+('N'<<16)+('3'<<24)
> > +    && *(short *)(&(ff_blk.lfn_magic[4])) == 0+('2'<<8) )
> >      {

No. You're forgetting the nul in "LFN32".

> > What parameters should I give to cvs to get the v2.03 update branch?
> 
> Note: 2.03 uses strcmp an additional place in the FNCASE code - so you
> can't easily eliminate strcmp there.

I don't quite understand this.

> 1) Create a completely separate working tree:
>     cvs checkout -r v2_03_1 djgpp

Ok.

> 2) Please don't commit anything unless we're sure we are building a
>    new distribution (we want to keep the two consistent).  If we wait
>    long enough we would need to branch v2_03_1 into v2_03_2 ;-P

I hope you don't mean the main version, because I already commited the
warning changes there.

But for the v2_03_1 branch, I won't as I haven't been messing with
it. But I thought you'd be interested in a similar patch there...


Right,

						MartinS