X-Authentication-Warning: delorie.com: mailnull set sender to djgpp-workers-bounces using -f
X-Authentication-Warning: new-smtp2.ihug.com.au: Host p483-apx1.syd.ihug.com.au [203.173.141.229] claimed to be acceleron
Message-ID: <007001c18d9a$79987880$0102a8c0@acceleron>
From: "Andrew Cottrell" <acottrel AT ihug DOT com DOT au>
To: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>,
   "Charles Sandmann" <sandmann AT clio DOT rice DOT edu>
Cc: <djgpp-workers AT delorie DOT com>
References: <10112251834 DOT AA25246 AT clio DOT rice DOT edu>
Subject: Re: Glob fix in new test version; +bash 2.04 change; now what?
Date: Wed, 26 Dec 2001 10:18:02 +1100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2600.0000
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
Reply-To: djgpp-workers AT delorie DOT com

IMHO I would update the files on clio and update the 2.03 refresh page to
indicate that an updated refresh is available. After a week if there are no
other issues send out an updated refresh anouncement and leave it another
week and then put the files onto Simtel.

Andrew

> > > What is the risk of adding this to the refresh vs. leaving the bug in?
> >
> > The risk of adding it is IMHO negligible, since the change simply tests
a
> > pointer against a fixed value and bails out if the test fails.
>
> I agree, but I've been burned with simple changes biting me :-)
>
> > The risk of leaving the bug in is that people will not be able to build
> > Bash without either resorting to local hacks, or using the CVS library.
>
> Bash 2.04 protected against it, bash 2.05 won't build with V2.03 anyway.
> But I updated the bsh204s.zip to disable the check and put a new bsh204b
> up.
>
> > So my advice would be to add it.
>
> It was such an evil bug (stack overflow) with such potentially terrible
> consequences, and a seemingly simple fix I didn't see a good reason not
> to include it.  Other than the 4 hours I spent rebuilding everything and
> building new distributions ...
>