X-Authentication-Warning: smtp3.ihug.com.au: Host p54-max1.syd.ihug.com.au [203.173.158.246] claimed to be acceleron
Message-ID: <007d01c171b5$8ee89130$0a02a8c0@acceleron>
From: "Andrew Cottrell" <acottrel AT ihug DOT com DOT au>
To: <djgpp-workers AT delorie DOT com>
References: <000d01c170ed$a6f46880$0a02a8c0 AT acceleron>
Subject: Re: GNU Grep alpha release 2.5e
Date: Tue, 20 Nov 2001 22:21:23 +1100
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2600.0000
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
Reply-To: djgpp-workers AT delorie DOT com


> I have uploaded the binary and source files (including unchecked DSM
files)
> to ftp://clio.rice.edu/djgpp/ . These files are not available from the
html
> page as I need to fix the HAVE_LIBPCRE first. I have ran a quick 5 minute
> test and grep worked.
I downloaded the CVS 2.5f code as this was suggested by the current Grep
maintainer that this may fix the it. I now get past the HAVE_LIBPCRE and now
find that DJGPP does not have support for S_ISSOCK(stats->stat.st_mode)
which was introduced in the changes since 2.5e. Should I get arround this by
defining it out for DJGPP as per the change below or define it in sys\stat.h
to always be false such as:-
        #define S_ISSOCK(m) (0x00)

The following is a code snippet from grep.c where  S_ISSOCK is used:

  if (fstat (fd, &stats->stat) != 0)
    {
      error (0, errno, "fstat");
      return 0;
    }
  if (directories == SKIP_DIRECTORIES && S_ISDIR (stats->stat.st_mode))
    return 0;
#ifdef DJGPP
  if (devices == SKIP_DEVICES && (S_ISCHR(stats->stat.st_mode) ||
S_ISBLK(stats->stat.st_mode)))
    return 0;
#else
  if (devices == SKIP_DEVICES && (S_ISCHR(stats->stat.st_mode) ||
S_ISBLK(stats->stat.st_mode) || S_ISSOCK(stats->stat.st_mode)))
    return 0;
#endif
  if (S_ISREG (stats->stat.st_mode))
    {
      if (file)
 bufoffset = 0;
      else
 {
   bufoffset = lseek (fd, 0, SEEK_CUR);
   if (bufoffset < 0)
     {
       error (0, errno, "lseek");
       return 0;
     }
 }

 > I have a few questions about this:-
>     1) Should I delete the redundant files in the DJGP directory?
>     2) Should I move the djgpp\readme file to the main grep directory and
> rename it to readme.dos?
>     3) Is there any problem as "releasing" this as an alpha release for
> DJGPP? By releaseing I mean put it on the main html page at clio and put
the
> sources and binary files to the incoming directory at delorie.com? (I need
> to build a 2.03+ DJGPP setup on my Win 98 PC before I can produce the
binary
> files to send )
>     4) Are important are the documentation zip files?

Anyone disagree with the following suggestions:-
1) Yes
2) Yes
3) No
4) Unknown.