Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3BF6B635.B356A548@phekda.freeserve.co.uk>
Date: Sat, 17 Nov 2001 19:10:45 +0000
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.19 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: djgpp-workers AT delorie DOT com
Subject: Which 2.13 DSMs (LONG) [Was: Re: Which 2.12.1 source and binary test zip 
 file]
References: <Pine DOT SUN DOT 3 DOT 91 DOT 1010924141908 DOT 26299C-100000 AT is> <004901c144fd$2d93f350$0a02a8c0 AT acceleron> <00bd01c16f5b$ae341340$0a02a8c0 AT acceleron>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

Andrew Cottrell wrote:
> I have included DSM files, but I don't know if they are correct or not.
> Could someone please check the DSM files out and send me updates if they
> are wrong.

The DSMs pass when I run dsmcheck. BTW if you want to check your DSMs,
install the zippo package and then run dsmcheck on the DSM files or
packages (either works):

    dsmcheck whic213?.zip

You don't need to configure zippo to use dsmcheck.

I could also install the binary package with zippo, with no trouble. The
source package also installs OK, but you will get warnings from zippo,
because it depends on TeX packages. I haven't written DSMs for the TeX
packages yet, so zippo will not know they are present.

When I install with zippo, I get the following warning:

    Info: Executing: install-info --info-file=c:/djgpp/info/which.info
--info-dir=c:/djgpp/info/
    install-info: warning: no info dir entry in `c:/djgpp/info/which.info'

This is zippo automatically trying to install an info directory entry for
which.info. (There is no support for commands in DSMs yet, so the
'builtin-post-install-script' is not actually executed.)

which.texinfo does not appear to have a directory entry. Perhaps you could
add one. Here's the texinfo I use for zippo:

    @ifinfo
    @dircategory DJGPP Package Management
    @direntry
    * zippo: (zippo).             zippo, a command-line package manager
    @end direntry
    @end ifinfo

I have a few comments about the DSMs:

* 'changelog' was introduced in version 0.4.4 of the DSM specification, so
dsm-version should be >= 0.4.4.

* There are 'maintainer*' directives, like the 'author*' directives, in
the DSM spec. There was a bug in zippo, which meant it didn't recognise
the 'maintainer*' directives, but that was fixed a while ago.

* Having a short description which includes the package type and version
is redundant, since zippo tells you the package version & type in its
short description queries ('zippo -q -a --short-info' for short info on
all packages).

* Only one readme is allowed per {pre,post}-{install,uninstall}. So if you
specify it twice or more, the last one in the DSM will be used. Would it
be useful to allow more than one README? Personally I think it might be
too much for the user to digest, but I can add the feature to the DSM spec
and zippo, if you'd like.

* The binary DSM has a 'dsm-name' that is the source DSM's name. This
causes problems when you install using zippo, since it uses the 'dsm-name'
to create an entry in its package database.

* Have you left 'dsm-author-email' and 'porter-email' blank to protect
your e-mail address? If so, you may as well leave these directives out.

Below is a diff that fixes these and a few typos. I also changed the
package version to 2.13, since it's 2.13 + DJGPP patches, which doesn't
need a new version IMO.

Thanks! Bye, Rich =]

-- 
Richard Dawe
http://www.phekda.freeserve.co.uk/richdawe/

--- whic213b.dsm.orig	Sat Nov 17 18:38:13 2001
+++ whic213b.dsm	Sat Nov 17 18:43:04 2001
@@ -1,28 +1,25 @@
 #
-# DSM for Which 2.13.1 sources.
+# DSM for Which 2.13 sources.
 # Written by Andrew Cottrell 16-Nov-2001
 #
 
-dsm-file-version: 1.0
-dsm-name: whic213s
-dsm-version: 0.4.0
-dsm-type: binaries
+dsm-file-version: 1.1
+dsm-name: whic213b
+dsm-version: 0.5.1
 
 dsm-author: Andrew Cottrell
-dsm-author-email: 
 
 name: which
-version: 2.13.1
+version: 2.13
+type: binaries
 manifest: whic213b
-binaries-dsm: whic213b
+sources-dsm: whic213s
 documentation-dsm: whic213d
-short-description: Sources for GNU which version 2.13.1
-long-description: GNU Which searches for filename in path
+short-description: GNU Which searches for filename in path
 
 license: GNU GPL
-# This is the current maintainer (until we have a maintainer: tag).
-author: Carlo Wood 
-author-email: carlo AT gnu DOT org
+maintainer: Carlo Wood 
+maintainer-email: carlo AT gnu DOT org
 # For reporting bugs
 mailing-list: bug-gnu-utils AT gnu DOT org
 # The home page of GNU which.
@@ -33,17 +30,15 @@ ftp-site:ftp://ftp.gnu.org/pub/gnu
 mailing-list: djgpp AT delorie DOT com
 newsgroup: comp.os.msdos.djgpp
 
-porter: Andre Cottrell
-porter-email: 
+porter: Andrew Cottrell
 
 simtelnet-path: v2gnu/
 zip: whic213b.zip
 
 changelog: gnu/which-2.13/ChangeLog
 
-
 post-install-readme: gnu/which-2.13/djgpp/README
-post-install-readme: gnu/which-2.13/djgpp/README.ORIG
+#post-install-readme: gnu/which-2.13/djgpp/README.ORIG
 
 requires: DPMI 0.9
 replaces: which < 2.13
--- whic213s.dsm.orig	Sat Nov 17 18:38:13 2001
+++ whic213s.dsm	Sat Nov 17 18:43:06 2001
@@ -1,28 +1,25 @@
 #
-# DSM for Which 2.13.1 sources.
+# DSM for Which 2.13 sources.
 # Written by Andrew Cottrell 16-Nov-2001
 #
 
-dsm-file-version: 1.0
+dsm-file-version: 1.1
 dsm-name: whic213s
-dsm-version: 0.4.0
-dsm-type: sources
+dsm-version: 0.5.1
 
 dsm-author: Andrew Cottrell
-dsm-author-email: 
 
 name: which
-version: 2.13.1
+version: 2.13
+type: sources
 manifest: whic213s
 binaries-dsm: whic213b
 documentation-dsm: whic213d
-short-description: Sources for GNU which version 2.13.1
-long-description: GNU Which searches for filename in path
+short-description: GNU Which searches for filename in path
 
 license: GNU GPL
-# This is the current maintainer (until we have a maintainer: tag).
-author: Carlo Wood 
-author-email: carlo AT gnu DOT org
+maintainer: Carlo Wood 
+maintainer-email: carlo AT gnu DOT org
 # For reporting bugs
 mailing-list: bug-gnu-utils AT gnu DOT org
 # The home page of GNU which.
@@ -33,8 +30,7 @@ ftp-site:ftp://ftp.gnu.org/pub/gnu
 mailing-list: djgpp AT delorie DOT com
 newsgroup: comp.os.msdos.djgpp
 
-porter: Andre Cottrell
-porter-email: 
+porter: Andrew Cottrell
 
 simtelnet-path: v2gnu/
 zip: whic213s.zip
@@ -42,7 +38,7 @@ zip: whic213s.zip
 changelog: gnu/which-2.13/ChangeLog
 
 post-install-readme: gnu/which-2.13/djgpp/README
-post-install-readme: gnu/which-2.13/djgpp/README.ORIG
+#post-install-readme: gnu/which-2.13/djgpp/README.ORIG
 
 # These are required to build GNU which:
 requires: DPMI 0.9
@@ -72,4 +68,3 @@ depends-on: groff
 depends-on: web2c
 depends-on: dvips
 depends-on: dvilj
-