Date: Sun, 11 Nov 2001 15:27:45 +0200 (IST)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender: eliz AT is
To: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
cc: DJGPP workers <djgpp-workers AT delorie DOT com>
Subject: Re: RESEND: Patch to computer st_blksize in struct stat
In-Reply-To: <3BEE6BCC.C6164CD0@phekda.freeserve.co.uk>
Message-ID: <Pine.SUN.3.91.1011111152354.6498A-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


On Sun, 11 Nov 2001, Richard Dawe wrote:

> Below is a patch to compute st_blksize in struct stat. This is basically
> the st_blocks patch with the st_blocks stuff removed.
> 
> OK to commit?

It's fine with me, but:

  1) Please don't use tolower (or any other ctype functions) when you 
     manipulate file names.  Only ASCII characters should be subject to
     case conversions, whereas ctype function are locale-sensitive.  So 
     please downcase with explicit code.

  2) I'm a bit worried by the possible slow-down, due to the call to 
     statfs.  Could you compare the old and the new versions, at least on 
     hard disks, floppies, and CDs?