Date: Sun, 14 Oct 2001 11:26:52 +0200 (IST)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender: eliz AT is
To: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
cc: DJGPP workers <djgpp-workers AT delorie DOT com>
Subject: Re: lseek & llseek: Move pipe check before dos interrupt
In-Reply-To: <3BC9524E.3898B00B@phekda.freeserve.co.uk>
Message-ID: <Pine.SUN.3.91.1011014112603.15625J-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


On Sun, 14 Oct 2001, Richard Dawe wrote:

> In lseek and llseek we check that the file descriptor is not a pipe, since
> you can't seek on pipes. But the check occurs after the DOS interrupt to
> do the seek. I think the check should be moved before the interrupt, but
> after the __FSEXT_lseek operation, to let FSEXT hooks do their thing.
> Below is a patch to do this.
> 
> OK to commit?

It's fine with me, but I'd like to hear Mark's approval as well, in case 
we are missing something here.