Date: Fri, 12 Oct 2001 00:34:17 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: "Eric Botcazou" <ebotcazou AT libertysurf DOT fr>
Message-Id: <7458-Fri12Oct2001003417+0200-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.9
CC: djgpp-workers AT delorie DOT com
In-reply-to: <00d901c152a0$398d6fa0$845824d5@zephyr>
	(ebotcazou AT libertysurf DOT fr)
Subject: Re: _findfirst() patch
References: <10110111357 DOT AA18726 AT clio DOT rice DOT edu> <006601c15277$3736ab00$d27824d5 AT zephyr> <1659-Thu11Oct2001211157+0200-eliz AT is DOT elta DOT co DOT il> <00d901c152a0$398d6fa0$845824d5 AT zephyr>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: "Eric Botcazou" <ebotcazou AT libertysurf DOT fr>
> Date: Thu, 11 Oct 2001 23:55:22 +0200
> 
> > No, this is slightly different.  _dos_findfirst only supports short
> > file names, for compatibility with DOS MSC compilers.  So it is not
> > equivalent to findfirst.
> 
> Yes, but half of the code of findfirst()/findnext() is duplicated in
> _dos_findfirst()/_dos_findnext(), so why not let the former functions call
> the latter if LFN is set to N ?

Pushing LFN=n into the environment in library functions is
``considered harmful'' around here.

> > Don't worry about this, we don't have any problems with adding a few
> > more modules to the library.
> 
> Ok, I can do it. But first I would like to know in which directory to put
> these low-level functions

I'd say put them in the same directory where findfisrt and findnext
live.

> and in which header file to declare them
> (libc/dosio.h ?).

No, I think dir.h is the place.  libc/dosio.h is for things that are
so private to the library that we don't want anyone to know about
them.

> Same thing for my helper function __dostime_to_time_t().

I suggest src/libc/dos/dos, there are similar functions there
already.

> According to DJ's rules, I think there is no need to document them
> in a .txh file, only in their source file.

Actually, it would be nice if every external function were documented.