Message-ID: <0c4501c12fb5$b62b6d90$9577d1d8@mnrpbapc0800>
From: "Michael Allison" <michael DOT allison2 AT sympatico DOT ca>
To: <djgpp-workers AT delorie DOT com>, "Charles Sandmann" <sandmann AT clio DOT rice DOT edu>
Cc: <djgpp-workers AT delorie DOT com>, <wojciech DOT galazka AT polkomtel DOT com DOT pl>
References: <Pine DOT SUN DOT 3 DOT 91 DOT 1010828092959 DOT 1704E-100000 AT is>
Subject: Re: ODP: Win2K/XP fixes - implementation review
Date: Tue, 28 Aug 2001 07:36:34 -0400
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4522.1200
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200
Reply-To: djgpp-workers AT delorie DOT com

From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
> I agree that it's better to test for the presence of bugs directly,
> but this could lead to many tests and many flag variables which tell
> what bugs are present.  If we can lump the bugs in a couple of
> categories, I think it's okay; otherwise, lets stay with version test.

You could get away with a single flag variable and still accommodate
up to 32 specific bugs.  If you had something like this:
    #define NTBUG1     0x01
    #define NTBUG2     0x02
    #define W2KBUG1  0x03
    #define NTLFN        0x04

    unsigned long known_nt_bugs;

and did your testing for all the conditions at startup, taking the
performance
hit there just once, the tests later could become a matter of this on NT:
    if (known_nt_bugs & W2KBUG1) {
    ...    /* bug specific workaround */
    }

and just this on non NT/W2K/XP environments:
    if (!known_nt_bugs) {
    ...
    }