Date: Fri, 17 Aug 2001 12:50:03 +0300
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: sandmann AT clio DOT rice DOT edu
Message-Id: <3791-Fri17Aug2001125002+0300-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.9
CC: djgpp-workers AT delorie DOT com
In-reply-to: <10108170353.AA14739@clio.rice.edu> (sandmann@clio.rice.edu)
Subject: Re: Building less
References:  <10108170353 DOT AA14739 AT clio DOT rice DOT edu>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: sandmann AT clio DOT rice DOT edu (Charles Sandmann)
> Date: Thu, 16 Aug 2001 22:53:04 -0500 (CDT)
> 
> I got the source.  I did a make, it builds OK on 2.03.  I clear the directory,
> point to the new include and libc.  Compiles fine, but on link I see:
> 
> /v204/djgpp/lib/libc.a(tmread.o)(.text+0x412):tmread.c: undefined reference to '__tty_screen_intface'
> /v204/djgpp/lib/libc.a(tmread.o)(.text+0x42f):tmread.c: undefined reference to '__tty_screen_intface'

I don't see this with today's CVS; perhaps you need to "cvs update"
and rebuild the library.

Also, how did you point to the new include and lib directories?  (I
used C_INCLUDE_PATH and LIBRARY_PATH in the environment.)

The problem seems to be that tmwrite.o, where the missing symbols are
defined, isn't linked in.  But I cannot understand why isn't it,
unless you have sources different from mine.

Anyway, if the latest library doesn't help, try the patch below (it
should have been a no-op, but somehow isn't).

> I could try to back patch the fixes into a 2.03 for testing?

It seems like it's a good idea to use a patched v2.03 anyway, because
Less built with the current CVS is broken: keys echo twice, BS
produces "^" instead of erasing the character to the left, etc.  Mark,
could you please look into this? it sounds like termios kicked in, but
it shouldn't have.  (To see the problems, type `/', top start a
search, then try typing something at the prompt; the same happens
after `E', which prompts for a file name.)

Charles, I'd suggest to apply the CVS patches to `select' alone, and
then debug the version of Less built with v2.03.  If you see problems
that are already fixed in CVS, just back-patch them into v2.03 as the
need arises.  Or perhaps you may wish to wait a few days until the
problem with termios is fixed.

Here's the patch I promised:

Index: src/libc/posix/termios/tmwrite.c
===================================================================
RCS file: /cvs/djgpp/djgpp/src/libc/posix/termios/tmwrite.c,v
retrieving revision 1.16
diff -u -r1.16 tmwrite.c
--- src/libc/posix/termios/tmwrite.c	2001/08/08 19:02:49	1.16
+++ src/libc/posix/termios/tmwrite.c	2001/08/17 09:33:17
@@ -24,7 +24,7 @@
 
 #define NPAR 16
 
-struct tty_screen_interface *__tty_screen_intface;
+struct tty_screen_interface *__tty_screen_intface = NULL;
 
 struct tty_screen_info __tty_screen;