Date: Sun, 01 Jul 2001 20:06:01 +0300
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: "Mark E." <snowball3 AT bigfoot DOT com>
Message-Id: <3405-Sun01Jul2001200600+0300-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.9
CC: djgpp-workers AT delorie DOT com
In-reply-to: <3B3E6ED6.5875.5395E1@localhost> (snowball3@bigfoot.com)
Subject: Re: v2loadimage proxy rev 3
References:  <3B3E6ED6 DOT 5875 DOT 5395E1 AT localhost>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: "Mark E." <snowball3 AT bigfoot DOT com>
> Date: Sun, 1 Jul 2001 00:29:10 -0400
> 
> This is rev 3 of changing v2loadimage to generate the proxy info 
> understandable by the startup code. I implemented Eli's suggestion as 
> follows:
> If the len byte 255 (0xff), the command line is assumed to be zero-terminated 
> and is parsed to generate proxy info (no matter how long or short the args 
> turn out to be). Otherwise, it's treated as a normal command tail.

Great!  The only comment I have now is about this:

> +     /* Provide a dummy command line that will be ignored when
> +        the proxy variable is found and parsed.  */
> +     proxy_cmdline[0] = 1;
> +     proxy_cmdline[1] = '\r';
> +     movedata(my_ds, (unsigned)proxy_cmdline, si.psp_selector, 128, 2);

I'm uneasy about this dummy command line: what if the debuggee somehow
disables the !proxy support in its startup code?  Isn't it safer to
pass it the first 126 characters of the command line, or what strlen
says about the length, whichever is smaller?