Date: Tue, 19 Jun 2001 15:20:09 -0400
Message-Id: <200106191920.PAA21440@envy.delorie.com>
X-Authentication-Warning: envy.delorie.com: dj set sender to dj AT envy DOT delorie DOT com using -f
From: DJ Delorie <dj AT delorie DOT com>
To: djgpp-workers AT delorie DOT com
In-reply-to: <200106191910.PAA13748@delorie.com> (cvs@delorie.com)
Subject: Re: djgpp: djgpp/include/grp.h,pwd.h,stdio.h,stdlib.h
References:  <200106191910 DOT PAA13748 AT delorie DOT com>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


> Modified Files:
> 	grp.h pwd.h stdio.h stdlib.h 
> Log Message:
> Added prototypes for a64l(), l64a() and unsetenv() to the not-ANSI-but-POSIX section
> Moved prototypes for putenv() and

This changelog appears truncated, but it seems like you're doing
multiple unrelated changes in one checkin (based on the diffs).
Please do separate commits for unrelated changes; that makes them
easier to review and discuss.

These next two changes may break binary compatibility.  The functions
I found all return just pointers, but could the size change cause
problems?

> ===================================================================
> RCS file: /cvs/djgpp/djgpp/include/grp.h,v
> 
> ===================================================================
> RCS file: /cvs/djgpp/djgpp/include/pwd.h,v

Please do not make gratuitous formatting changes, especially in
conjunction with other changes.

> ===================================================================
> RCS file: /cvs/djgpp/djgpp/include/stdio.h,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -p -2 -r1.5 -r1.6
> *** djgpp/include/stdio.h	2001/06/09 20:33:22	1.5
> --- djgpp/include/stdio.h	2001/06/19 19:10:15	1.6
> *************** __DJ_size_t
> --- 49,60 ----
>      
>   typedef struct {
> !   int     _cnt;
> !   char   *_ptr;
> !   char   *_base;
> !   size_t  _bufsiz;
> !   int     _flag;
> !   int     _file;
> !   char   *_name_to_remove;
> !   size_t  _fillsize;
>   } FILE;

Why this change?  Are these functions also part of the new posix spec?

> *************** int	vsprintf(char *_s, const char *_form
> *** 118,123 ****
> --- 118,128 ----
>   int	fileno(FILE *_stream);
>   FILE *	fdopen(int _fildes, const char *_type);
> + int	mkstemp(char *_template);
>   int	pclose(FILE *_pf);
>   FILE *	popen(const char *_command, const char *_mode);
> + char *	tempnam(const char *_dir, const char *_prefix);
> + int	vfscanf(FILE *_stream, const char *_format, va_list _ap);
> + int	vscanf(const char *_format, va_list _ap);
> + int	vsscanf(const char *_s, const char *_format, va_list _ap);
>   
>   #ifndef _POSIX_SOURCE
> *************** int	_doscan_low(FILE *, int (*)(FILE *_g
> *** 135,148 ****
>   int	fpurge(FILE *_f);
>   int	getw(FILE *_f);
> - int	mkstemp(char *_template);
>   char *	mktemp(char *_template);
>   int	putw(int _v, FILE *_f);
>   void	setbuffer(FILE *_f, void *_buf, int _size);
>   void	setlinebuf(FILE *_f);
> - char *	tempnam(const char *_dir, const char *_prefix);
>   int	_rename(const char *_old, const char *_new);	/* Simple (no directory) */
> - int	vfscanf(FILE *_stream, const char *_format, va_list _ap);
> - int	vscanf(const char *_format, va_list _ap);
> - int	vsscanf(const char *_s, const char *_format, va_list _ap);
>   
>   #endif /* !_POSIX_SOURCE */