From: "Tim Van Holder" <tim DOT van DOT holder AT pandora DOT be>
To: <djgpp-workers AT delorie DOT com>
Subject: Re: [patch] Second draft: a64l and l64a
Date: Mon, 4 Jun 2001 22:11:49 +0200
Message-ID: <CAEGKOHJKAAFPKOCLHDIMEOFCDAA.tim.van.holder@pandora.be>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2910.0)
In-reply-to: <7458-Mon04Jun2001213334+0300-eliz@is.elta.co.il>
Importance: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Thanks.  Now that I _really_ see the text, I have a few more minor
> comments:
> 
> [snip: TeXinfo formatting suggestions]

Will do.

> > This function takes a @code{long} argument and returns a pointer to its
> > radix-64 representation.  Negative numbers are not supported.
> > @c FIXME: Supporting negative values (or at least unsigned longs) seems
> > @c        more logical; should we be POSIX-compliant here?
> 
> You can now remove that FIXME, and instead say what did your code do
> with negative values.

Right - this was an oversight.

> > diff -rN emptydir/makefile src/libc/posix/stdlib/makefile
> > 0a1,7
> > > # Copyright (C) 2001 DJ Delorie, see COPYING.DJ for details
> > >
> > > TOP=../..
> > >
> > > SRC += a64l.c l64a.c
> 
> I think we normally put only one file on a line.  DJ, is that a
> standard we should enforce?

I'll change this as well.