From: "Mark E." <snowball3 AT bigfoot DOT com>
To: djgpp-workers AT delorie DOT com (DJGPP-WORKERS)
Date: Sat, 31 Mar 2001 14:45:33 -0500
MIME-Version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Subject: Re: Bug00323, final? (LONG)
Message-ID: <3AC5ED8D.31331.28E89B@localhost>
In-reply-to: <200103311757.TAA23410@mother.ludd.luth.se>
X-mailer: Pegasus Mail for Win32 (v3.12c)
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Just one or two nits from me:

> RCS file: /cvs/djgpp/djgpp/src/libc/dos/io/fd_props.c,v
> +  if (cur_fd->filename && (open_flags & O_APPEND))
> +    cur_fd->flags |= FILE_DESC_APPEND;

I don't think the filename check is needed in this case because the append 
code doesn't care what the filename is.

> RCS file: /cvs/djgpp/djgpp/src/libc/posix/fcntl/open.c,v
> +  /*  int append_mode = (oflag & O_APPEND);*/

> +  /*  if (append_mode)
> +    __file_handle_modes[fd] |= O_APPEND;*/

Leftovers from a previous version?