Date: Sun, 25 Mar 2001 10:22:12 +0200 (IST)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender: eliz AT is
To: "Mark E." <snowball3 AT bigfoot DOT com>
cc: djgpp-workers AT delorie DOT com
Subject: Re: new pipe patch
In-Reply-To: <3ABD3110.20018.23D9EC@localhost>
Message-ID: <Pine.SUN.3.91.1010325102132.23422H@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


On Sat, 24 Mar 2001, Mark E. wrote:

> This version adds a pipe property so lseek can detect a file descriptor with 
> this property and set ESPIPE accordingly.

Thanks.

Looks okay, except for these two nits:

>   @subheading Description
>   
> ! This function creates a pipe and places a file descriptor for the read end
> ! of the pipe in @code{fildes[0]}, and another for the write end in
> ! @code{fildes[1]}.  Data written to @code{fildes[1]} will be read from
> ! @code{fildes[0]} on a first-in first-out (FIFO) basis.

"fildes" should have a @var markup, since it's a formal argument of
`pipe', like this:

     @code{@var{fildes}[0]}

> + Zero for success, otherwise -1 is returned and @var{errno} is set

"errno" is _not_ a formal argument, so it should have the @code
markup.