From: "Laurynas Biveinis" <lauras AT softhome DOT net>
Date: Sun, 18 Mar 2001 14:31:22 +0200
To: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
Cc: rich AT phekda DOT freeserve DOT co DOT uk, djgpp-workers AT delorie DOT com
Subject: Re: Patch for fileutils 4.0 WRT symlinks
Message-ID: <20010318143122.B1580@lauras.lt>
Mail-Followup-To: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>,
	rich AT phekda DOT freeserve DOT co DOT uk, djgpp-workers AT delorie DOT com
References: <20010317113611 DOT A199 AT lauras DOT lt> <6137-Sat17Mar2001120203+0200-eliz AT is DOT elta DOT co DOT il> <20010317121103 DOT A286 AT lauras DOT lt> <3405-Sat17Mar2001184657+0200-eliz AT is DOT elta DOT co DOT il>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.15i
In-Reply-To: <3405-Sat17Mar2001184657+0200-eliz@is.elta.co.il>; from eliz@is.elta.co.il on Sat, Mar 17, 2001 at 06:46:58PM +0200
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


> > > > -#ifdef  __DJGPP__
> > > > -/* DJGPP doesn't have S_ISLNK defined, because MS-DOS doesn't support links.
> > > > - * However, DJGPP's `link' simulates hard links by copying, and we can
> > > > - * have ``symbolic links'' for DJGPP .EXE programs.  Therefore, just
> > > > - * for the purpose of this program, it makes sense to define S_ISLNK
> > > > - * so we could have working `ln'.  */
> > > > -
> > > > -#define S_ISLNK(x)  (0)     /* defined, but no file is a link */
> > > > -#endif

> > Do you really want to condition quoted excerpt on HAVE_WORKING_LSTAT?
> > I think this macro is suitable for lstat() in djutils.c only. Here you
> > really need __DJGPP_MINOR__.
> 
> I don't see why.  Perhaps I'm missing something.

If the patch is going to be offered upstream, then it should work with
all sane and insane systems out there. You want to define S_ISLNK if
HAVE_WORKING_LSTAT is not defined. And what about some system which does
not support symbolic links but has a trivial lstat() implementation?

Laurynas