Date: Sat, 17 Mar 2001 18:46:58 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: lauras AT softhome DOT net
Message-Id: <3405-Sat17Mar2001184657+0200-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.6
CC: rich AT phekda DOT freeserve DOT co DOT uk, djgpp-workers AT delorie DOT com
In-reply-to: <20010317121103.A286@lauras.lt>
Subject: Re: Patch for fileutils 4.0 WRT symlinks
References: <20010317113611 DOT A199 AT lauras DOT lt> <6137-Sat17Mar2001120203+0200-eliz AT is DOT elta DOT co DOT il> <20010317121103 DOT A286 AT lauras DOT lt>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: "Laurynas Biveinis" <lauras AT softhome DOT net>
> Date: Sat, 17 Mar 2001 12:11:03 +0200
> 
> > > -#ifdef  __DJGPP__
> > > -/* DJGPP doesn't have S_ISLNK defined, because MS-DOS doesn't support links.
> > > - * However, DJGPP's `link' simulates hard links by copying, and we can
> > > - * have ``symbolic links'' for DJGPP .EXE programs.  Therefore, just
> > > - * for the purpose of this program, it makes sense to define S_ISLNK
> > > - * so we could have working `ln'.  */
> > > -
> > > -#define S_ISLNK(x)  (0)     /* defined, but no file is a link */
> > > -#endif
> > 
> > I'd prefer for this to be conditioned on HAVE_WORKING_LSTAT, so that
> > Fileutils could be built with older versions of DJGPP.  
> 
> Do you really want to condition quoted excerpt on HAVE_WORKING_LSTAT?
> I think this macro is suitable for lstat() in djutils.c only. Here you
> really need __DJGPP_MINOR__.

I don't see why.  Perhaps I'm missing something.