Date: Wed, 28 Feb 2001 23:22:01 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: "Mark E." <snowball3 AT bigfoot DOT com>
Message-Id: <1659-Wed28Feb2001232200+0200-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.6
CC: djgpp-workers AT delorie DOT com
In-reply-to: <3A9D10EE.3225.494F82@localhost> (snowball3@bigfoot.com)
Subject: Re: O_TEMPORARY v3
References:  <3A9D10EE DOT 3225 DOT 494F82 AT localhost>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: "Mark E." <snowball3 AT bigfoot DOT com>
> Date: Wed, 28 Feb 2001 14:53:34 -0500
> 
> I made some minor tweaks and added documentation for the support
> functions and wc204.txi.

Thanks!

> however I'm not sure about one change I made:
> 
> *************** open(const char* filename, int oflag, .. *** 107,113 ****
> }  
> 
>     if (should_create)
> !     fd = _creatnew(real_name, dmode, oflag & 0xff);
>     else
>     {
>       fd = _open(real_name, oflag);
> --- 109,115 ----
>       }
> 
>     if (should_create)
> !     fd = _creatnew(real_name, dmode, oflag);
>     else
>     {
>       fd = _open(real_name, oflag);
> 
> 
> If the masking with 0xff is neccessary, I can rework that part.

What is the value of O_TEMPORARY?  (Btw, I don't see the diffs for
fcntl.h in the patches.)

> + @findex O_TEMPORARYr{, new flag accepted by @code{open}}
                       ^^
This should be @r{, not r{.

> + See also @ref{__set_fd_properties} and @ref{__dup_fd_properties}.

You cannot use "@ref" on its own, you have to say "see" or something
else.