Date: Fri, 23 Feb 2001 23:07:17 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: "Mark E." <snowball3 AT bigfoot DOT com>
Message-Id: <7263-Fri23Feb2001230717+0200-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.6
CC: djgpp-workers AT delorie DOT com
In-reply-to: <3A965F2B.10227.264CB2@localhost> (snowball3@bigfoot.com)
Subject: Re: O_TEMPORARY v2
References: <3A95981A DOT 14546 DOT 31CA2 AT localhost> (snowball3 AT bigfoot DOT com) <3A965F2B DOT 10227 DOT 264CB2 AT localhost>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: "Mark E." <snowball3 AT bigfoot DOT com>
> Date: Fri, 23 Feb 2001 13:01:31 -0500
>
> > > *************** open(const char* filename, int oflag, ..
> > > *** 152,157 ****
> > > --- 153,161 ----
> > >     if(oflag & O_APPEND)
> > >       lseek(fd, 0, SEEK_END);
> > > 
> > > +   if (oflag)
> > > +     _set_fd_properties(fd, real_name, oflag);
> > > +     
> > 
> > Isn't it better to put this into _open instead of open?  The opposite
> > operation is inside _close, not close.
> 
> Doesn't matter to me, but then wouldn't the same code need to be added to 
> _creatnew since open calls it too?

Yes, _creatnew should have this added as well.