Date: Fri, 26 Jan 2001 11:28:39 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: "Mark E." <snowball3 AT bigfoot DOT com>
Message-Id: <2593-Fri26Jan2001112838+0200-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.6
CC: djgpp-workers AT delorie DOT com
In-reply-to: <3A70BB10.7477.23FC70@localhost> (snowball3@bigfoot.com)
Subject: Re: lfilelen patch
References:  <3A70BB10 DOT 7477 DOT 23FC70 AT localhost>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: "Mark E." <snowball3 AT bigfoot DOT com>
> Date: Thu, 25 Jan 2001 23:47:28 -0500
> 
> This is essentially Peter Farley's patch for lfilelength but modifed
> to use 0x71a6 when available.

Thanks!

> +  * Copyright (c) 1994 Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>

I think at least ``modified by'' is in order.  This code is so
different from what I wrote back then...

> + #include <libc/stubs.h>
> + #include <errno.h>
> + #include <dpmi.h>
> + #include <go32.h>
> + #include <libc/dosio.h>
> + #include <sys/farptr.h>
> + #include <dos.h>
> + 
> + long long __lfilelength (int);
> + 
> + long long
> + __lfilelength(int fhandle)

Since stubs.h has an entry for lfilelength, you don't need (and
shouldn't) use __lfilelength here.  Use lfilelength instead.

> + @subheading Return Value
> + 
> + The size of the file in bytes, or (if any error occured) -1L and
                                                             ^^^
This should be "-1LL".

> + The return value is of type long long which allows file sizes of

Please put "long long" into @code{}.

> + 2^63-2 bytes to be returned. Note that FAT16 limits files to near
> + 2^31 bytes and FAT32 limits files to 2^32-2 bytes.

Mathematical expressions like 2^63-2 look better in print if you give
them the @math markup.

Also, please make sure you have 2 spaces after the dot which ends a
sentence.

Finally, please add an entry to wc204.txi about lfilelength.

Other than these minor comments, I think the changes can go in.