From: lauras AT softhome DOT net
Date: Sun, 7 Jan 2001 13:37:21 +0200
To: djgpp-workers AT delorie DOT com
Subject: Re: Bug in lstat() - wrong arguments to FSEXT
Message-ID: <20010107133721.A1337@lauras.lt>
References: <3A571D5F DOT 36413161 AT phekda DOT freeserve DOT co DOT uk> <Pine DOT SUN DOT 3 DOT 91 DOT 1010107120611 DOT 21289S-100000 AT is>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <Pine.SUN.3.91.1010107120611.21289S-100000@is>; from eliz@is.elta.co.il on Sun, Jan 07, 2001 at 12:08:27PM +0200
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Sun, Jan 07, 2001 at 12:08:27PM +0200, Eli Zaretskii wrote:
> 
> On Sat, 6 Jan 2001, Richard Dawe wrote:
> 
> > There appears to be a bug in lstat() - see line 910 of
> > src/libc/posix/sys/stat/lstat.c:
> > 
> >    if (__FSEXT_call_open_handlers(__FSEXT_stat, &ret, &real_path))
> >      return ret;
> > 
> > __FSEXT_call_open_handlers() should be called with the third arg as a
> > va_list, not a pointer like this.
> 
> I think this is a result of replacing `path' with `real_path' when 
> symlink support was added to `stat': the former was on the stack, since 
> it's the argument of `stat' (now `lstat'), and so passing a pointer to 
> it does TRT, evebn though it is not declared as a va_list.
>
Well spotted, thanks. I'll fix this shortly, also I'll try to
make a testsuite for this case.

Laurynas