Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <39D78F08.1A3B81A1@phekda.freeserve.co.uk>
Date: Sun, 01 Oct 2000 20:22:48 +0100
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.51 [en] (X11; I; Linux 2.2.14 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
CC: DJGPP workers <djgpp-workers AT delorie DOT com>
Subject: Re: Porting Fileutils 4.0: chgrp, chown, df
References: <39D71D69 DOT 7268DF4F AT phekda DOT freeserve DOT co DOT uk> <9003-Sun01Oct2000211247+0300-eliz AT is DOT elta DOT co DOT il>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

Eli Zaretskii wrote:
> > * 'chown' has a slightly different problem. We can modify the user
> >   and group. The original code has been modified to support
> >   DJGPP - modified so that it always succeeds, no matter what $USER
> >   and $GROUP are. Clearly, 'chgrp' and 'chown' should be consistent.
> 
> Yes, they should be consistent.
> 
> I suggest to look at the ported Tar, as I believe the solution I found
> there is much more clean.  The relevant file is lib/userspec.c.  In a
> nutshell, if you want the library to ``know'' about a user "foo" and a
> group "bar", simply execute these two lines just before the code which
> needs that:
> 
>       setenv ("USER", "foo", 1);
>       setenv ("GROUP", "bar", 1);

Actually, this code is already present in lib/userspec.c, so I guess your
changes have been incorporated into Fileutils 4.0. ;) It seems that
'chgrp' doesn't use the code in lib/userspec.c like 'chmod', so I'll make
a similar change for 'chgrp'.

> > I wonder if some basic user and group support could be added to DJGPP,
[snip]
> This looks like an overkill.  The ``solutions'' along the above lines
> are working in several ports for many years, and no one has yet
> complained.

If no-one's complained, then I guess this solution works well enough. I'll
make them always succeed.

> > * 'df' needs patching to support joined drives.
[snip]
> I have a working DOS 5.0 machine where I can test JOINed drives.

Thanks, I'd appreciate that.

Hopefully I'll have the second alpha of the port out in a couple of days.

Thanks, bye,

-- 
Richard Dawe
[ mailto:richdawe AT bigfoot DOT com | http://www.bigfoot.com/~richdawe/ ]